Description
The code does not explicitly delimit a block that is intended to contain 2 or more statements, creating a logic error.
In some languages, braces (or other delimiters) are optional for blocks. When the delimiter is omitted, it is possible to insert a logic error in which a statement is thought to be in a block but is not. In some cases, the logic error can have security implications.
Modes of Introduction:
– Implementation
Likelihood of Exploit: Low
Related Weaknesses
Consequences
Confidentiality, Integrity, Availability: Alter Execution Logic
This is a general logic error which will often lead to obviously-incorrect behaviors that are quickly noticed and fixed. In lightly tested or untested code, this error may be introduced it into a production environment and provide additional attack vectors by creating a control flow path leading to an unexpected state in the application. The consequences will depend on the types of behaviors that are being incorrectly executed.
Potential Mitigations
Phase: Implementation
Description:
Always use explicit block delimitation and use static-analysis technologies to enforce this practice.
CVE References
- CVE-2014-1266
- incorrect indentation of “goto” statement makes it more difficult to detect an incorrect goto (Apple’s “goto fail”)